]> git.ipfire.org Git - thirdparty/linux.git/commit
virtio-blk: Ensure no requests in virtqueues before deleting vqs.
authorYi Sun <yi.sun@unisoc.com>
Mon, 29 Jan 2024 08:52:50 +0000 (16:52 +0800)
committerJens Axboe <axboe@kernel.dk>
Thu, 8 Feb 2024 18:30:26 +0000 (11:30 -0700)
commit4ce6e2db00de8103a0687fb0f65fd17124a51aaa
treef1d2b668e079df800225d164e718e1d87906703e
parent2a427b49d02995ea4a6ff93a1432c40fa4d36821
virtio-blk: Ensure no requests in virtqueues before deleting vqs.

Ensure no remaining requests in virtqueues before resetting vdev and
deleting virtqueues. Otherwise these requests will never be completed.
It may cause the system to become unresponsive.

Function blk_mq_quiesce_queue() can ensure that requests have become
in_flight status, but it cannot guarantee that requests have been
processed by the device. Virtqueues should never be deleted before
all requests become complete status.

Function blk_mq_freeze_queue() ensure that all requests in virtqueues
become complete status. And no requests can enter in virtqueues.

Signed-off-by: Yi Sun <yi.sun@unisoc.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Link: https://lore.kernel.org/r/20240129085250.1550594-1-yi.sun@unisoc.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/block/virtio_blk.c