]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
Drivers: hv: vmbus: Remove the useless API vmbus_get_outgoing_channel()
authorDexuan Cui <decui@microsoft.com>
Mon, 26 Nov 2018 02:17:56 +0000 (02:17 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 26 Nov 2018 19:21:21 +0000 (20:21 +0100)
commit4d3c5c69191f98c7f7e699ff08d2fd96d7070ddb
treeda0446badd2f32c0f8201ac499db2b45f22f96f6
parent6b50d882d38d5a1e4c0c476712384067c19c744b
Drivers: hv: vmbus: Remove the useless API vmbus_get_outgoing_channel()

Commit d86adf482b84 ("scsi: storvsc: Enable multi-queue support") removed
the usage of the API in Jan 2017, and the API is not used since then.

netvsc and storvsc have their own algorithms to determine the outgoing
channel, so this API is useless.

And the API is potentially unsafe, because it reads primary->num_sc without
any lock held. This can be risky considering the RESCIND-OFFER message.

Let's remove the API.

Cc: Long Li <longli@microsoft.com>
Cc: Stephen Hemminger <sthemmin@microsoft.com>
Cc: K. Y. Srinivasan <kys@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Dexuan Cui <decui@microsoft.com>
Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/hv/channel.c
drivers/hv/channel_mgmt.c
include/linux/hyperv.h