]> git.ipfire.org Git - thirdparty/qemu.git/commit
hw/display/qxl-render.c: fix qxl_unpack_chunks() chunk size calculation
authorMichael Tokarev <mjt@tls.msk.ru>
Fri, 21 Feb 2025 13:34:52 +0000 (16:34 +0300)
committerMichael Tokarev <mjt@tls.msk.ru>
Mon, 28 Jul 2025 15:58:26 +0000 (18:58 +0300)
commit4d7cc3805abf18c99a0c775756f54279c125b17d
treecc0e946cf3de17a0c00d815a26624339fb42cb55
parentddedb92861cc9440b16748ec67971ecacfc8891f
hw/display/qxl-render.c: fix qxl_unpack_chunks() chunk size calculation

In case of multiple chunks, code in qxl_unpack_chunks() takes size of the
wrong (next in the chain) chunk, instead of using current chunk size.
This leads to wrong number of bytes being copied, and to crashes if next
chunk size is larger than the current one.

Based on the code by Gao Yong.

Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1628
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
Reviewed-by: Thomas Huth <thuth@redhat.com>
(cherry picked from commit b8882becd572d3afb888c836a6ffc7f92c17d1c5)
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
hw/display/qxl-render.c