]> git.ipfire.org Git - thirdparty/openembedded/openembedded-core-contrib.git/commit
buildtools-tarball: fix unbound variable issues under 'set -u'
authorHaixiao Yan <haixiao.yan.cn@windriver.com>
Fri, 12 Sep 2025 01:59:33 +0000 (09:59 +0800)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Mon, 15 Sep 2025 16:52:52 +0000 (17:52 +0100)
commit4d880c2eccd534133a2a4e6579d955605c0956ec
tree7e46646ffec764ea13dcffed019af29f0b8b0cbb
parent005377ea98f73af37dc8596668ab40e6b63c0b28
buildtools-tarball: fix unbound variable issues under 'set -u'

When Bash runs with 'set -u' (nounset), accessing an unset variable
directly (e.g. [ -z "$SSL_CERT_FILE" ]) causes a fatal "unbound variable"
error. As a result, the fallback logic to set SSL_CERT_FILE/SSL_CERT_DIR
is never triggered and the script aborts.

The current code assumes these variables may be unset or empty, but does
not guard against 'set -u'. This breaks builds in stricter shell
environments or when users explicitly enable 'set -u'.

Fix this by using parameter expansion with a default value, e.g.
"${SSL_CERT_FILE:-}", so that unset variables are treated as empty
strings. This preserves the intended logic (respect host env first, then
CAFILE/CAPATH, then buildtools defaults) and makes the script robust
under 'set -u'.

Signed-off-by: Haixiao Yan <haixiao.yan.cn@windriver.com>
Signed-off-by: Mathieu Dubois-Briand <mathieu.dubois-briand@bootlin.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
meta/recipes-connectivity/openssl/files/environment.d-openssl.sh
meta/recipes-devtools/git/git/environment.d-git.sh
meta/recipes-devtools/python/python3-requests/environment.d-python3-requests.sh
meta/recipes-support/curl/curl/environment.d-curl.sh