]> git.ipfire.org Git - thirdparty/qemu.git/commit
migration: Cleanup incoming migration setup state change
authorPeter Xu <peterx@redhat.com>
Wed, 19 Jun 2024 22:30:39 +0000 (18:30 -0400)
committerFabiano Rosas <farosas@suse.de>
Fri, 21 Jun 2024 12:47:59 +0000 (09:47 -0300)
commit4dd5f7b8d568116b3ce594b0055a47c6db50f49c
treed8366d09cca0ec66b2f9ec92e1622c6010ad5c9f
parenta5c24e13e9f176901058b460e61425756322f3e8
migration: Cleanup incoming migration setup state change

Destination QEMU can setup incoming ports for two purposes: either a fresh
new incoming migration, in which QEMU will switch to SETUP for channel
establishment, or a paused postcopy migration, in which QEMU will stay in
POSTCOPY_PAUSED until kicking off the RECOVER phase.

Now the state machine worked on dest node for the latter, only because
migrate_set_state() implicitly will become a noop if the current state
check failed.  It wasn't clear at all.

Clean it up by providing a helper migration_incoming_state_setup() doing
proper checks over current status.  Postcopy-paused will be explicitly
checked now, and then we can bail out for unknown states.

Reviewed-by: Fabiano Rosas <farosas@suse.de>
Signed-off-by: Peter Xu <peterx@redhat.com>
Signed-off-by: Fabiano Rosas <farosas@suse.de>
migration/migration.c