]> git.ipfire.org Git - thirdparty/haproxy.git/commit
BUG/MEDIUM: patterns: previous fix was incomplete
authorWilly Tarreau <w@1wt.eu>
Wed, 26 Nov 2014 12:17:03 +0000 (13:17 +0100)
committerWilly Tarreau <w@1wt.eu>
Wed, 26 Nov 2014 12:17:03 +0000 (13:17 +0100)
commit4deaf39243c4d941998b1b0175bad05b8a287c0b
tree584a23ea8469486d160036a50c46ef9e23950033
parent3b24641745b32289235d765f441ec60fa7381f99
BUG/MEDIUM: patterns: previous fix was incomplete

Dmitry Sivachenko <trtrmitya@gmail.com> reported that commit 315ec42
("BUG/MEDIUM: pattern: don't load more than once a pattern list.")
relies on an uninitialised variable in the stack. While it used to
work fine during the tests, if the uninitialized variable is non-null,
some patterns may be aggregated if loaded multiple times, resulting in
slower processing, which was the original issue it tried to address.

The fix needs to be backported to 1.5.
src/pattern.c