]> git.ipfire.org Git - thirdparty/linux.git/commit
usb: typec: mux: Fix unsigned comparison with less than zero
authorYueHaibing <yuehaibing@huawei.com>
Tue, 19 Feb 2019 06:57:50 +0000 (14:57 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 19 Feb 2019 13:26:45 +0000 (14:26 +0100)
commit4e46f271c37415323f2b650d02ef50c87ff8d092
treed22ec27b2a2a35735f4bb13b874a614743de89fc
parentdc8b2a691dc8f25ca6764236ed27df7c87239dd9
usb: typec: mux: Fix unsigned comparison with less than zero

The return from the call to fwnode_property_read_u16_array is int,
it can be a negative error code however this is being assigned to
an size_t variable 'nval', hence the check is always false.
Fix this by making 'nval' an int.

Detected by Coccinelle ("Unsigned expression compared with
zero: nval < 0")

Fixes: 96a6d031ca99 ("usb: typec: mux: Find the muxes by also matching against the device node")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Acked-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/typec/mux.c