]> git.ipfire.org Git - people/arne_f/kernel.git/commit
gpio: mvebu: fix pwm .get_state period calculation
authorBaruch Siach <baruch@tkos.co.il>
Sun, 17 Jan 2021 13:17:02 +0000 (15:17 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 30 Jan 2021 12:32:11 +0000 (13:32 +0100)
commit4e5ee86dcb0003ae9ed0b477e47a1d0aaf2f8c67
tree76fe5f65173ee73d7008b491b9a864660d7140a7
parentc4ff839de17f38b0ae0f8983b5c5186f8a389238
gpio: mvebu: fix pwm .get_state period calculation

commit e73b0101ae5124bf7cd3fb5d250302ad2f16a416 upstream.

The period is the sum of on and off values. That is, calculate period as

  ($on + $off) / clkrate

instead of

  $off / clkrate - $on / clkrate

that makes no sense.

Reported-by: Russell King <linux@armlinux.org.uk>
Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Fixes: 757642f9a584e ("gpio: mvebu: Add limited PWM support")
Signed-off-by: Baruch Siach <baruch@tkos.co.il>
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
[baruch: backport to kernels <= v5.10]
Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Baruch Siach <baruch@tkos.co.il>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/gpio/gpio-mvebu.c