]> git.ipfire.org Git - people/arne_f/kernel.git/commit
exportfs: do not read dentry after free
authorPan Bian <bianpan2016@163.com>
Fri, 23 Nov 2018 07:56:33 +0000 (15:56 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 17 Dec 2018 09:07:10 +0000 (10:07 +0100)
commit4eb2095c80a56fec125c06465a2f61dcc3ed5369
tree3e635b59ea10371bf877a4fc3095f3dedbeceb60
parentba318581cddd7a254cf854fa9ad8bd5170edd18e
exportfs: do not read dentry after free

[ Upstream commit 2084ac6c505a58f7efdec13eba633c6aaa085ca5 ]

The function dentry_connected calls dput(dentry) to drop the previously
acquired reference to dentry. In this case, dentry can be released.
After that, IS_ROOT(dentry) checks the condition
(dentry == dentry->d_parent), which may result in a use-after-free bug.
This patch directly compares dentry with its parent obtained before
dropping the reference.

Fixes: a056cc8934c("exportfs: stop retrying once we race with
rename/remove")

Signed-off-by: Pan Bian <bianpan2016@163.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Sasha Levin <sashal@kernel.org>
fs/exportfs/expfs.c