]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Fix uninitialized access to InitialRunningXacts during decoding.
authorAmit Kapila <akapila@postgresql.org>
Fri, 25 Nov 2022 03:45:31 +0000 (09:15 +0530)
committerAmit Kapila <akapila@postgresql.org>
Fri, 25 Nov 2022 03:45:31 +0000 (09:15 +0530)
commit4ec157c15067be979d271416dacf86a5fce34cbc
tree8e19045a27b5bd6b3357bc2619995e50ddd80b2e
parent5a185246f9a742371a75ac0e3a95d0ceba9494e5
Fix uninitialized access to InitialRunningXacts during decoding.

In commit 272248a0c, we introduced an InitialRunningXacts array to
remember transactions and subtransactions that were running when the
xl_running_xacts record that we decoded was written. This array was
allocated in the snapshot builder memory context after we restore
serialized snapshot but we forgot to reset the array while freeing the
builder memory context. So, the next time when we start decoding in the
same session where we don't restore any serialized snapshot, we ended up
using the uninitialized array and that can lead to unpredictable behavior.

This problem doesn't exist in HEAD as instead of using
InitialRunningXacts, we added the list of transaction IDs and
sub-transaction IDs, that have modified catalogs and are running during
snapshot serialization, to the serialized snapshot (see commit 7f13ac8123).

Reported-by: Maxim Orlov
Author: Masahiko Sawada
Reviewed-by: Amit Kapila, Maxim Orlov
Backpatch-through: 11
Discussion: https://postgr.es/m/CACG=ezZoz_KG+Ryh9MrU_g5e0HiVoHocEvqFF=NRrhrwKmEQJQ@mail.gmail.com
src/backend/replication/logical/snapbuild.c