]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
ARM: zynq: Use memcpy_toio instead of memcpy on smp bring-up
authorLuis Araneda <luaraneda@gmail.com>
Thu, 8 Aug 2019 12:52:43 +0000 (08:52 -0400)
committerBen Hutchings <ben@decadent.org.uk>
Tue, 10 Dec 2019 18:01:12 +0000 (18:01 +0000)
commit4f0a684f9d14e81f8ade8236b01518fb5169b978
treefe50c9a9b6b8c822231f31a584f24aed40974163
parentb1dfec05ec4413c62fa553e9740a98f443c9487b
ARM: zynq: Use memcpy_toio instead of memcpy on smp bring-up

commit b7005d4ef4f3aa2dc24019ffba03a322557ac43d upstream.

This fixes a kernel panic on memcpy when
FORTIFY_SOURCE is enabled.

The initial smp implementation on commit aa7eb2bb4e4a
("arm: zynq: Add smp support")
used memcpy, which worked fine until commit ee333554fed5
("ARM: 8749/1: Kconfig: Add ARCH_HAS_FORTIFY_SOURCE")
enabled overflow checks at runtime, producing a read
overflow panic.

The computed size of memcpy args are:
- p_size (dst): 4294967295 = (size_t) -1
- q_size (src): 1
- size (len): 8

Additionally, the memory is marked as __iomem, so one of
the memcpy_* functions should be used for read/write.

Fixes: aa7eb2bb4e4a ("arm: zynq: Add smp support")
Signed-off-by: Luis Araneda <luaraneda@gmail.com>
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
arch/arm/mach-zynq/platsmp.c