]> git.ipfire.org Git - thirdparty/qemu.git/commit
hw/net: Fix NULL dereference with software RSS
authorAkihiko Odaki <akihiko.odaki@daynix.com>
Thu, 16 Jan 2025 07:30:43 +0000 (16:30 +0900)
committerMichael Tokarev <mjt@tls.msk.ru>
Tue, 25 Feb 2025 06:45:46 +0000 (09:45 +0300)
commit4f5adbe6974414aea3ba7c13adf156e824d2f45c
tree9dcd3d3ede3b9b092f5f9991b3597524dc0cd222
parent437999ae814470f4b738b8860a7080498151cae3
hw/net: Fix NULL dereference with software RSS

When an eBPF program cannot be attached, virtio_net_load_ebpf() returns
false, and virtio_net_device_realize() enters the code path to handle
errors because of this, but it causes NULL dereference because no error
is generated.

Change virtio_net_load_ebpf() to return false only when a fatal error
occurred.

Fixes: b5900dff14e5 ("hw/net: report errors from failing to use eBPF RSS FDs")
Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Message-Id: <20250116-software-v1-1-9e5161b534d8@daynix.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
(cherry picked from commit bc82af6b0dcb0933e72640851fdd2594f822b23e)
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
hw/net/virtio-net.c