]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
tools/mm/slabinfo: fix access to null terminator in string boundary
authorKaushlendra Kumar <kaushlendra.kumar@intel.com>
Sat, 30 Aug 2025 17:20:22 +0000 (22:50 +0530)
committerAndrew Morton <akpm@linux-foundation.org>
Sun, 21 Sep 2025 21:22:00 +0000 (14:22 -0700)
commit4fa5b88e772372e7ea3faccd0bbab03cb32104ed
treef32d1fe4a5c8dca3de292b51b0b68d64b88e8ba4
parent5a00878f78cf4ef12bd5dcea88ed4dd1ef0c7433
tools/mm/slabinfo: fix access to null terminator in string boundary

The current code incorrectly accesses buffer[strlen(buffer)], which points
to the null terminator ('\0') at the end of the string.  This is
technically out-of-bounds access since valid string content ends at index
strlen(buffer)-1.

Fix by:
1. Declaring strlen() result variable at function scope
2. Adding bounds check (len > 0) to handle empty strings
3. Using buffer[len-1] to correctly access the last character before
   the null terminator

[kaushlendra.kumar@intel.com: remove unnecessary blank line]
Link: https://lkml.kernel.org/r/20250901044955.3902815-1-kaushlendra.kumar@intel.com
Link: https://lkml.kernel.org/r/20250830172022.1927448-1-kaushlendra.kumar@intel.com
Signed-off-by: Kaushlendra Kumar <kaushlendra.kumar@intel.com>
Acked-by: SeongJae Park <sj@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
tools/mm/slabinfo.c