]> git.ipfire.org Git - thirdparty/qemu.git/commit
hw/arm/xlnx-zynqmp: fix unsigned error when checking the RPUs number
authorClément Chigot <chigot@adacore.com>
Wed, 24 May 2023 14:37:14 +0000 (16:37 +0200)
committerMichael Tokarev <mjt@tls.msk.ru>
Wed, 31 May 2023 06:42:37 +0000 (09:42 +0300)
commit505f0c68c9bd571353ee6ef4679e2192aa3f712f
tree802f7edbec169a30cef698c6338b0ff0de432de8
parentcdda1ce15847045972c3ec7d84b7f51fb84ecc5f
hw/arm/xlnx-zynqmp: fix unsigned error when checking the RPUs number

When passing --smp with a number lower than XLNX_ZYNQMP_NUM_APU_CPUS,
the expression (ms->smp.cpus - XLNX_ZYNQMP_NUM_APU_CPUS) will result
in a positive number as ms->smp.cpus is a unsigned int.
This will raise the following error afterwards, as Qemu will try to
instantiate some additional RPUs.
  | $ qemu-system-aarch64 --smp 1 -M xlnx-zcu102
  | **
  | ERROR:../src/tcg/tcg.c:777:tcg_register_thread:
  |   assertion failed: (n < tcg_max_ctxs)

Signed-off-by: Clément Chigot <chigot@adacore.com>
Reviewed-by: Francisco Iglesias <frasse.iglesias@gmail.com>
Tested-by: Francisco Iglesias <frasse.iglesias@gmail.com>
Message-id: 20230524143714.565792-1-chigot@adacore.com
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
(cherry picked from commit c9ba1c9f02cfede5329f504cdda6fd3a256e0434)
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
hw/arm/xlnx-zynqmp.c