]> git.ipfire.org Git - thirdparty/postgresql.git/commit
vacuumdb: don't prompt for passwords over and over
authorAlvaro Herrera <alvherre@alvh.no-ip.org>
Thu, 12 Nov 2015 21:05:23 +0000 (18:05 -0300)
committerAlvaro Herrera <alvherre@alvh.no-ip.org>
Thu, 12 Nov 2015 21:05:23 +0000 (18:05 -0300)
commit5094da99b901df42580b6e7494d036ee4be9eb81
treef879bf36a6d9c73811447fb114788ac7a12bb350
parent747854f010b168c4f076cf44b61b100b0fe20866
vacuumdb: don't prompt for passwords over and over

Having the script prompt for passwords over and over was a preexisting
problem when it processed multiple databases or when it processed
multiple analyze stages, but the parallel mode introduced in commit
a179232047 made it worse.

Fix the annoyance by keeping a copy of the password used by the first
connection that requires one.  Since users can (currently) only have a
single password, there's no need for more complex arrangements (such as
remembering one password per database).

Per bug #13741 reported by Eric Brown.  Patch authored and
cross-reviewed by Haribabu Kommi and Michael Paquier, slightly tweaked
by Álvaro Herrera.

Discussion: http://www.postgresql.org/message-id/20151027193919.931.54948@wrigleys.postgresql.org
Backpatch to 9.5, where parallel vacuumdb was introduced.
src/bin/scripts/clusterdb.c
src/bin/scripts/common.c
src/bin/scripts/common.h
src/bin/scripts/createlang.c
src/bin/scripts/createuser.c
src/bin/scripts/droplang.c
src/bin/scripts/dropuser.c
src/bin/scripts/reindexdb.c
src/bin/scripts/vacuumdb.c