]> git.ipfire.org Git - thirdparty/qemu.git/commit
target/i386: fix direction of "32-bit MMU" test
authorPaolo Bonzini <pbonzini@redhat.com>
Mon, 11 Mar 2024 07:56:44 +0000 (08:56 +0100)
committerMichael Tokarev <mjt@tls.msk.ru>
Thu, 21 Mar 2024 16:57:05 +0000 (19:57 +0300)
commit509525dc67ba2cbf39a1cecf53af84383922f966
tree8749c009cec7d9031e0ec33669afb5df1b00230f
parent1ced8cd5413db0c11f1e0fe31c50c49ba863d7f8
target/i386: fix direction of "32-bit MMU" test

The low bit of MMU indices for x86 TCG indicates whether the processor is
in 32-bit mode and therefore linear addresses have to be masked to 32 bits.
However, the index was computed incorrectly, leading to possible conflicts
in the TLB for any address above 4G.

Analyzed-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Fixes: b1661801c18 ("target/i386: Fix physical address truncation", 2024-02-28)
Fixes: a28b6b4e743 ("target/i386: Fix physical address truncation" in stable-8.2)
Cc: qemu-stable@nongnu.org
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2206
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
(cherry picked from commit 2cc68629a6fc198f4a972698bdd6477f883aedfb)
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
(Mjt: move changes for x86_cpu_mmu_index() to cpu_mmu_index() due to missing
 v8.2.0-1030-gace0c5fe59 "target/i386: Populate CPUClass.mmu_index")
target/i386/cpu.h