]> git.ipfire.org Git - thirdparty/git.git/commit
bisect--helper: avoid use-after-free
authorTanushree Tumane <tanushreetumane@gmail.com>
Mon, 9 Dec 2019 10:56:47 +0000 (11:56 +0100)
committerJunio C Hamano <gitster@pobox.com>
Wed, 11 Dec 2019 17:24:27 +0000 (09:24 -0800)
commit51a0a4ed9597e949930d92be59f42f991bc40a7c
tree5f74d207d7f6b8bf0e792a082a4f683f344b2e91
parent367f12b7e92aef4e8a41fe601d90984a2b7a0381
bisect--helper: avoid use-after-free

In 5e82c3dd22a (bisect--helper: `bisect_reset` shell function in C,
2019-01-02), the `git bisect reset` subcommand was ported to C. When the
call to `git checkout` failed, an error message was reported to the
user.

However, this error message used the `strbuf` that had just been
released already. Let's switch that around: first use it, then release
it.

Mentored-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Mentored-by: Christian Couder <chriscool@tuxfamily.org>
Signed-off-by: Tanushree Tumane <tanushreetumane@gmail.com>
Signed-off-by: Miriam Rubio <mirucam@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
builtin/bisect--helper.c