git.ipfire.org Git - people/ms/linux.git/commit

author	Stefan Richter <stefanr@s5r6.in-berlin.de>
	Tue, 18 Feb 2014 21:25:15 +0000 (22:25 +0100)
committer	Jiri Slaby <jslaby@suse.cz>
	Sat, 22 Mar 2014 21:01:56 +0000 (22:01 +0100)
commit	52fa2d887232da81aee604c560db9383a2d1369e
tree	2bca77ceb04b64bb4adc82b5eebb9ecfc157ecd3	tree \| snapshot
parent	95a3d2c55f8f15f8219816baf4e4c705ea992bbe	commit \| diff

firewire: net: fix use after free

commit 8987583366ae9e03c306c2b7d73bdb952df1d08d upstream.

Commit 8408dc1c14c1 "firewire: net: use dev_printk API" introduced a
use-after-free in a failure path. fwnet_transmit_packet_failed(ptask)
may free ptask, then the dev_err() call dereferenced it. The fix is
straightforward; simply reorder the two calls.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>