]> git.ipfire.org Git - thirdparty/linux.git/commit
selftests: mptcp: connect: -f: no reconnect
authorMatthieu Baerts (NGI0) <matttbe@kernel.org>
Tue, 4 Feb 2025 22:19:53 +0000 (23:19 +0100)
committerJakub Kicinski <kuba@kernel.org>
Thu, 6 Feb 2025 01:54:32 +0000 (17:54 -0800)
commit5368a67307b3b2c347dc8965ac55b888be665934
tree7201d40aa4ccdf0cf593d870e0212aea0509ab35
parenta1300691aed9ee852b0a9192e29e2bdc2411a7e6
selftests: mptcp: connect: -f: no reconnect

The '-f' parameter is there to force the kernel to emit MPTCP FASTCLOSE
by closing the connection with unread bytes in the receive queue.

The xdisconnect() helper was used to stop the connection, but it does
more than that: it will shut it down, then wait before reconnecting to
the same address. This causes the mptcp_join's "fastclose test" to fail
all the time.

This failure is due to a recent change, with commit 218cc166321f
("selftests: mptcp: avoid spurious errors on disconnect"), but that went
unnoticed because the test is currently ignored. The recent modification
only shown an existing issue: xdisconnect() doesn't need to be used
here, only the shutdown() part is needed.

Fixes: 6bf41020b72b ("selftests: mptcp: update and extend fastclose test-cases")
Cc: stable@vger.kernel.org
Reviewed-by: Mat Martineau <martineau@kernel.org>
Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
Link: https://patch.msgid.link/20250204-net-mptcp-sft-conn-f-v1-1-6b470c72fffa@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
tools/testing/selftests/net/mptcp/mptcp_connect.c