]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
f2fs: fix to avoid dirent corruption
authorChao Yu <chao@kernel.org>
Tue, 28 Nov 2023 09:25:16 +0000 (17:25 +0800)
committerJaegeuk Kim <jaegeuk@kernel.org>
Tue, 28 Nov 2023 18:52:04 +0000 (10:52 -0800)
commit53edb549565f55ccd0bdf43be3d66ce4c2d48b28
tree51939b58ebe58449c2b62a73a105b1b7b378a755
parentbbd3efed3383e332191c665786c61653826d2ac3
f2fs: fix to avoid dirent corruption

As Al reported in link[1]:

f2fs_rename()
...
if (old_dir != new_dir && !whiteout)
f2fs_set_link(old_inode, old_dir_entry,
old_dir_page, new_dir);
else
f2fs_put_page(old_dir_page, 0);

You want correct inumber in the ".." link.  And cross-directory
rename does move the source to new parent, even if you'd been asked
to leave a whiteout in the old place.

[1] https://lore.kernel.org/all/20231017055040.GN800259@ZenIV/

With below testcase, it may cause dirent corruption, due to it missed
to call f2fs_set_link() to update ".." link to new directory.
- mkdir -p dir/foo
- renameat2 -w dir/foo bar

[ASSERT] (__chk_dots_dentries:1421)  --> Bad inode number[0x4] for '..', parent parent ino is [0x3]
[FSCK] other corrupted bugs                           [Fail]

Fixes: 7e01e7ad746b ("f2fs: support RENAME_WHITEOUT")
Cc: Jan Kara <jack@suse.cz>
Reported-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Chao Yu <chao@kernel.org>
Reviewed-by: Jan Kara <jack@suse.cz>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
fs/f2fs/namei.c