]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
block: Do not force full zone append completion in req_bio_endio()
authorDamien Le Moal <dlemoal@kernel.org>
Thu, 28 Mar 2024 00:43:40 +0000 (09:43 +0900)
committerJens Axboe <axboe@kernel.dk>
Thu, 28 Mar 2024 23:04:48 +0000 (17:04 -0600)
commit55251fbdf0146c252ceff146a1bb145546f3e034
tree641f2df4d39b3e7f58759179b175e7f8d36a6a36
parent038105a200689ae07eb9e804ca2295e628a45820
block: Do not force full zone append completion in req_bio_endio()

This reverts commit 748dc0b65ec2b4b7b3dbd7befcc4a54fdcac7988.

Partial zone append completions cannot be supported as there is no
guarantees that the fragmented data will be written sequentially in the
same manner as with a full command. Commit 748dc0b65ec2 ("block: fix
partial zone append completion handling in req_bio_endio()") changed
req_bio_endio() to always advance a partially failed BIO by its full
length, but this can lead to incorrect accounting. So revert this
change and let low level device drivers handle this case by always
failing completely zone append operations. With this revert, users will
still see an IO error for a partially completed zone append BIO.

Fixes: 748dc0b65ec2 ("block: fix partial zone append completion handling in req_bio_endio()")
Cc: stable@vger.kernel.org
Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Link: https://lore.kernel.org/r/20240328004409.594888-2-dlemoal@kernel.org
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block/blk-mq.c