]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
bpf: Reject negative offsets for ALU ops
authorYazhou Tang <tangyazhou518@outlook.com>
Tue, 30 Sep 2025 15:04:33 +0000 (23:04 +0800)
committerAlexei Starovoitov <ast@kernel.org>
Wed, 1 Oct 2025 22:43:13 +0000 (15:43 -0700)
commit55c0ced59fe17dee34e9dfd5f7be63cbab207758
treeaf28c0cc29c7a82b4f5b858eb49e623d08d7b86c
parent1bd3773aad5411f3542aa2e5328df58454706ca6
bpf: Reject negative offsets for ALU ops

When verifying BPF programs, the check_alu_op() function validates
instructions with ALU operations. The 'offset' field in these
instructions is a signed 16-bit integer.

The existing check 'insn->off > 1' was intended to ensure the offset is
either 0, or 1 for BPF_MOD/BPF_DIV. However, because 'insn->off' is
signed, this check incorrectly accepts all negative values (e.g., -1).

This commit tightens the validation by changing the condition to
'(insn->off != 0 && insn->off != 1)'. This ensures that any value
other than the explicitly permitted 0 and 1 is rejected, hardening the
verifier against malformed BPF programs.

Co-developed-by: Shenghao Yuan <shenghaoyuan0928@163.com>
Signed-off-by: Shenghao Yuan <shenghaoyuan0928@163.com>
Co-developed-by: Tianci Cao <ziye@zju.edu.cn>
Signed-off-by: Tianci Cao <ziye@zju.edu.cn>
Signed-off-by: Yazhou Tang <tangyazhou518@outlook.com>
Acked-by: Yonghong Song <yonghong.song@linux.dev>
Fixes: ec0e2da95f72 ("bpf: Support new signed div/mod instructions.")
Link: https://lore.kernel.org/r/tencent_70D024BAE70A0A309A4781694C7B764B0608@qq.com
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
kernel/bpf/verifier.c