]> git.ipfire.org Git - thirdparty/qemu.git/commit
tests/qtest/migration: Fix file migration offset check
authorFabiano Rosas <farosas@suse.de>
Mon, 17 Jun 2024 18:57:18 +0000 (15:57 -0300)
committerFabiano Rosas <farosas@suse.de>
Thu, 20 Jun 2024 13:42:24 +0000 (10:42 -0300)
commit55fc0c2f68ec81cc51f39964cf6d1bf3f7467a4f
tree838eb28364cd49b511713cec587cd61eead38aae
parent6d3279655ac49b806265f08415165f471d33e032
tests/qtest/migration: Fix file migration offset check

When doing file migration, QEMU accepts an offset that should be
skipped when writing the migration stream to the file. The purpose of
the offset is to allow the management layer to put its own metadata at
the start of the file.

We have tests for this in migration-test, but only testing that the
migration stream starts at the correct offset and not that it actually
leaves the data intact. Unsurprisingly, there's been a bug in that
area that the tests didn't catch.

Fix the tests to write some data to the offset region and check that
it's actually there after the migration.

While here, switch to using g_get_file_contents() which is more
portable than mmap().

Reviewed-by: Peter Xu <peterx@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Fabiano Rosas <farosas@suse.de>
tests/qtest/migration-test.c