]> git.ipfire.org Git - thirdparty/openssl.git/commit
Revert "Delay setting the sig algs until after the cert_cb has been called"
authorBenjamin Kaduk <bkaduk@akamai.com>
Thu, 13 Jun 2019 19:04:52 +0000 (12:04 -0700)
committerBenjamin Kaduk <kaduk@mit.edu>
Wed, 26 Jun 2019 17:59:04 +0000 (12:59 -0500)
commit572492aaf0657fd40c96b889966350ce20d310b4
tree304444845f0c077913177fe26bd557b2deca790b
parent9863b41989968fd88d1b772ac7e20e3cdaea8beb
Revert "Delay setting the sig algs until after the cert_cb has been called"

This reverts commit 524006dd1b80c1a86a20119ad988666a80d8d8f5.

While this change did prevent the sigalgs from getting inadvertently
clobbered by SSL_set_SSL_CTX(), it also caused the sigalgs to not be
set when the cert_cb runs.  This, in turn, caused significant breakage,
such as SSL_check_chain() failing to find any valid chain.  An alternate
approach to fixing the issue from #7244 will follow.

Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/9157)

(cherry picked from commit 6f34d7bc7d0c7fcd86c6f2772f26e42c925d8505)
ssl/statem/statem_srvr.c