]> git.ipfire.org Git - thirdparty/git.git/commit
builtin/pack-objects.c: avoid redundant NULL check
authorTaylor Blau <me@ttaylorr.com>
Tue, 24 May 2022 18:54:27 +0000 (14:54 -0400)
committerJunio C Hamano <gitster@pobox.com>
Tue, 24 May 2022 21:27:19 +0000 (14:27 -0700)
commit58a6abb7bae98357677657825631de6652256be9
tree7c139860a173394cb6d2eec7d893b143a684d17e
parent44f9fd649673362bdbaae7067a9919b1fe4c96d1
builtin/pack-objects.c: avoid redundant NULL check

Before calling `for_each_object_in_pack()`, the caller
`read_packs_list_from_stdin()` loops through each of the `include_packs`
and checks that its `->util` pointer (which is used to store the `struct
packed_git *` itself) is non-NULL.

This check is redundant, because `read_packs_list_from_stdin()` already
checks that the included packs are non-NULL earlier on in the same
function (and it does not add any new entries in between).

Remove this check, since it is not doing anything in the meantime.

Co-authored-by: Victoria Dye <vdye@github.com>
Signed-off-by: Taylor Blau <me@ttaylorr.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
builtin/pack-objects.c