]> git.ipfire.org Git - thirdparty/libvirt.git/commit
qemu: hot-plug: Fix broken SCSI disk hot-plug
authorMarc Hartmayer <mhartmay@linux.vnet.ibm.com>
Mon, 27 Jun 2016 14:43:46 +0000 (16:43 +0200)
committerPeter Krempa <pkrempa@redhat.com>
Thu, 30 Jun 2016 10:48:51 +0000 (12:48 +0200)
commit58d07db9b0c294e92e294cadd737eee8597bf747
treec1e5d2912a323e4a8486d8ac5ae44148420c60d4
parentbb848feec0f3f10e92dd8e5231ae7aa89b5598f3
qemu: hot-plug: Fix broken SCSI disk hot-plug

The commit "qemu: hot-plug: Assume support for -device in
qemuDomainAttachSCSIDisk" dropped the code for the automatic SCSI
controller creation used in SCSI disk hot-plugging. If we are
hot-plugging a SCSI disk to a domain and there is no proper SCSI
controller defined, it results in an "error: internal error: Could not
find scsi controller with index X required for device" error.

For that reason reverting a hunk of the commit
d4d32005d6e8b2cc0a2f26b483ca1de10171db6d.

This patch also adds an extra comment to the code to clarify the
loop.

Reviewed-by: Boris Fiuczynski <fiuczy@linux.vnet.ibm.com>
Reviewed-by: Bjoern Walk <bwalk@linux.vnet.ibm.com>
Signed-off-by: Marc Hartmayer <mhartmay@linux.vnet.ibm.com>
src/qemu/qemu_hotplug.c