]> git.ipfire.org Git - thirdparty/glibc.git/commit
Skip PT_DYNAMIC segment with p_filesz == 0 [BZ #22101]
authorH.J. Lu <hjl.tools@gmail.com>
Tue, 26 Sep 2017 20:49:48 +0000 (13:49 -0700)
committerH.J. Lu <hjl.tools@gmail.com>
Tue, 26 Sep 2017 20:50:01 +0000 (13:50 -0700)
commit592d5c75392e1da170050a4999af0618c4865aed
treea0f9b248f75e6be63bf3aa9794e37b01ad6398c4
parent2d9193f2f55767c71333d425e140e22c3e15dc3d
Skip PT_DYNAMIC segment with p_filesz == 0 [BZ #22101]

ELF objects generated with "objcopy --only-keep-debug" have

Type     Offset  VirtAddr   PhysAddr   FileSiz MemSiz  Flg Align
DYNAMIC  0x0+e28 0x0+200e40 0x0+200e40 0x0+    0x0+1a0 RW  0x8

with 0 file size. ld.so should skip such PT_DYNAMIC segments.

Without a PT_DYNAMIC segment the loading of the shared object will
fail, and therefore ldd on such objects will also fail instead of
crashing. This provides better diagnostics for tooling that is
attempting to inspect the invalid shared objects which may just
contain debug information.

[BZ #22101]
* elf/Makefile (tests): Add tst-debug1.
($(objpfx)tst-debug1): New.
($(objpfx)tst-debug1.out): Likewise.
($(objpfx)tst-debug1mod1.so): Likewise.
* elf/dl-load.c (_dl_map_object_from_fd): Skip PT_DYNAMIC segment
with p_filesz == 0.
* elf/tst-debug1.c: New file.

Reviewed-by: Carlos O'Donell <carlos@redhat.com>
ChangeLog
elf/Makefile
elf/dl-load.c
elf/tst-debug1.c [new file with mode: 0644]