]> git.ipfire.org Git - thirdparty/libvirt.git/commit
qemu: Fix persistent migration of transient domains
authorJiri Denemark <jdenemar@redhat.com>
Tue, 2 May 2017 16:01:04 +0000 (18:01 +0200)
committerJiri Denemark <jdenemar@redhat.com>
Tue, 2 May 2017 16:53:19 +0000 (18:53 +0200)
commit59307fade86fb74db1f8f572433962233f7ac123
treea164051731b97c91fb0c6f50c12a45bd00c545c5
parent71890992daf37ec78b00b4ce873369421dc99731
qemu: Fix persistent migration of transient domains

While fixing a bug with incorrectly freed memory in commit
v3.1.0-399-g5498aa29a, I accidentally broke persistent migration of
transient domains. Before adding qemuDomainDefCopy in the path, the code
just took NULL from vm->newDef and used it as the persistent def, which
resulted in no persistent XML being sent in the migration cookie. This
scenario is perfectly valid and the destination correctly handles it by
using the incoming live definition and storing it as the persistent one.

After the mentioned commit libvirtd would just segfault in the described
scenario.

https://bugzilla.redhat.com/show_bug.cgi?id=1446205

Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
src/qemu/qemu_migration.c