]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
of: overlay: add missing of_node_get() in __of_attach_node_sysfs
authorFrank Rowand <frank.rowand@sony.com>
Fri, 5 Oct 2018 03:26:05 +0000 (20:26 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 6 Feb 2019 16:27:44 +0000 (17:27 +0100)
commit5933abd0743489f89d165cdfd372467d9c100c8f
treee58a7961cb645c42717472b881c98f8c0ddc3930
parent0aa65adc854a6e08e9c932df834c5d3a5b617836
of: overlay: add missing of_node_get() in __of_attach_node_sysfs

commit 5b2c2f5a0ea3a43e0dee78059e34c7cb54136dcc upstream.

There is a matching of_node_put() in __of_detach_node_sysfs()

Remove misleading comment from function header comment for
of_detach_node().

This patch may result in memory leaks from code that directly calls
the dynamic node add and delete functions directly instead of
using changesets.

This commit should result in powerpc systems that dynamically
allocate a node, then later deallocate the node to have a
memory leak when the node is deallocated.

The next commit will fix the leak.

Tested-by: Alan Tull <atull@kernel.org>
Acked-by: Michael Ellerman <mpe@ellerman.id.au> (powerpc)
Signed-off-by: Frank Rowand <frank.rowand@sony.com>
Cc: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/of/dynamic.c
drivers/of/kobj.c