]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
nvme/tcp: handle tls partially sent records in write_space()
authorWilfred Mallawa <wilfred.mallawa@wdc.com>
Fri, 10 Oct 2025 07:19:42 +0000 (17:19 +1000)
committerKeith Busch <kbusch@kernel.org>
Thu, 16 Oct 2025 18:32:04 +0000 (11:32 -0700)
commit5a869d017793399fd1d2609ff27e900534173eb3
tree28d73bb305501bbc4557e34d458dcc53bc3bbae5
parent7e091add9c433bab6912228799bf508e2414acc3
nvme/tcp: handle tls partially sent records in write_space()

With TLS enabled, records that are encrypted and appended to TLS TX
list can fail to see a retry if the underlying TCP socket is busy, for
example, hitting an EAGAIN from tcp_sendmsg_locked(). This is not known
to the NVMe TCP driver, as the TLS layer successfully generated a record.

Typically, the TLS write_space() callback would ensure such records are
retried, but in the NVMe TCP Host driver, write_space() invokes
nvme_tcp_write_space(). This causes a partially sent record in the TLS TX
list to timeout after not being retried.

This patch fixes the above by calling queue->write_space(), which calls
into the TLS layer to retry any pending records.

Fixes: be8e82caa685 ("nvme-tcp: enable TLS handshake upcall")
Signed-off-by: Wilfred Mallawa <wilfred.mallawa@wdc.com>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: Keith Busch <kbusch@kernel.org>
drivers/nvme/host/tcp.c