]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
drm: hold gem reference until object is no longer accessed
authorSteve Cohen <cohens@codeaurora.org>
Mon, 20 Jul 2020 22:30:50 +0000 (18:30 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 5 Aug 2020 07:58:38 +0000 (09:58 +0200)
commit5aa4eb5a6d915cf00bf104ddd76e1adbc3dabdc4
tree38360d7eec823a913f7c980420599a107de12be6
parentc71d5b14b2dbece82940b55e5e08da9e9a7f47c3
drm: hold gem reference until object is no longer accessed

commit 8490d6a7e0a0a6fab5c2d82d57a3937306660864 upstream.

A use-after-free in drm_gem_open_ioctl can happen if the
GEM object handle is closed between the idr lookup and
retrieving the size from said object since a local reference
is not being held at that point. Hold the local reference
while the object can still be accessed to fix this and
plug the potential security hole.

Signed-off-by: Steve Cohen <cohens@codeaurora.org>
Cc: stable@vger.kernel.org
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/1595284250-31580-1-git-send-email-cohens@codeaurora.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/gpu/drm/drm_gem.c