]> git.ipfire.org Git - thirdparty/git.git/commit
t5312: be more assertive about command failure
authorJeff King <peff@peff.net>
Fri, 24 Sep 2021 18:37:11 +0000 (14:37 -0400)
committerJunio C Hamano <gitster@pobox.com>
Mon, 27 Sep 2021 19:36:45 +0000 (12:36 -0700)
commit5b062e1f79b5121296678d91b2bbd032ca86a866
treeb8e06a524406c5d3fe882abfdb68b95764a21b7a
parent078eecbcbe04bf77e8b9afee01a58c905c3b3c50
t5312: be more assertive about command failure

When repacking or pruning in a corrupted repository, our tests in t5312
argue that it is OK to complete the operation or bail, as long as we
don't actually delete the objects pointed to by the corruption.

This isn't a wrong line of reasoning, but the tests are a bit permissive
by using test_might_fail. The fact is that we _do_ bail currently, and
if we ever stopped doing so, that would be worthy of a human
investigating. So let's switch these to test_must_fail.

Signed-off-by: Jeff King <peff@peff.net>
Reviewed-by: Jonathan Tan <jonathantanmy@google.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
t/t5312-prune-corruption.sh