]> git.ipfire.org Git - thirdparty/nftables.git/commit
trace: do not remove icmp type from packet dump
authorFlorian Westphal <fw@strlen.de>
Mon, 8 Feb 2021 14:54:44 +0000 (15:54 +0100)
committerFlorian Westphal <fw@strlen.de>
Mon, 8 Feb 2021 15:06:09 +0000 (16:06 +0100)
commit5b1fb140a0db0e14d036face850dad3a4e209901
treeadb0924def1d553d7e08580af5826fa379a55862
parente6c32b2fa0b820bc81cbb99e8ed601eabbbfac69
trace: do not remove icmp type from packet dump

As of 0.9.8 the icmp type is marked as a protocol field, so its
elided in 'nft monitor trace' output:

   icmp code 0 icmp id 44380 ..

Restore it.  Unlike tcp, where 'tcp sport' et. al in the dump
will make the 'ip protocol tcp' redundant this case isn't obvious
in the icmp case:

  icmp type 8 code 0 id ...

Reported-by: Martin Gignac <martin.gignac@gmail.com>
Fixes: 98b871512c4677 ("src: add auto-dependencies for ipv4 icmp")
Signed-off-by: Florian Westphal <fw@strlen.de>
src/netlink.c