]> git.ipfire.org Git - thirdparty/Python/cpython.git/commit
[3.12] gh-108973: Fix asyncio test_subprocess_consistent_callbacks() (GH-109431)...
authorMiss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Mon, 2 Oct 2023 15:03:51 +0000 (08:03 -0700)
committerGitHub <noreply@github.com>
Mon, 2 Oct 2023 15:03:51 +0000 (17:03 +0200)
commit5ba9d2b98f13c509cec560cb1de8de1630463e5c
tree23a496da0d012935e078265576077a23af2070e3
parentc3038bed1df2dc0399379cec81544a3d725674ef
[3.12] gh-108973: Fix asyncio test_subprocess_consistent_callbacks() (GH-109431) (#109609)

gh-108973: Fix asyncio test_subprocess_consistent_callbacks() (GH-109431)

SubprocessProtocol process_exited() method can be called before
pipe_data_received() and pipe_connection_lost() methods. Document it
and adapt the test for that.

Revert commit 282edd7b2a74c4dfe1bfe3c5b1d30f9c21d554d6.
_child_watcher_callback() calls immediately _process_exited(): don't
add an additional delay with call_soon(). The reverted change didn't
make _process_exited() more determistic: it can still be called
before pipe_connection_lost() for example.

(cherry picked from commit ced6924630037f1e5b3d1dbef2b600152fb07fbb)

Co-authored-by: Victor Stinner <vstinner@python.org>
Co-authored-by: Davide Rizzo <sorcio@gmail.com>
Doc/library/asyncio-llapi-index.rst
Doc/library/asyncio-protocol.rst
Lib/asyncio/unix_events.py
Lib/test/test_asyncio/test_subprocess.py