]> git.ipfire.org Git - thirdparty/nftables.git/commit
src: Fix cache_flush() in cache_needs_more() logic
authorPhil Sutter <phil@nwl.cc>
Tue, 4 Jun 2019 17:31:49 +0000 (19:31 +0200)
committerPablo Neira Ayuso <pablo@netfilter.org>
Thu, 6 Jun 2019 09:19:08 +0000 (11:19 +0200)
commit5c1c6028dbd54dd56e57fb8a18d1e7e61586e8bf
treeff008a36d30c67ab64d01eaed7c4ab19696abe15
parent7df42800cf89e994b5179200825592d9b95c5fab
src: Fix cache_flush() in cache_needs_more() logic

Commit 34a20645d54fa enabled cache updates depending on command causing
it. As a side-effect, this disabled measures in cache_flush() preventing
a later cache update. Re-establish this by setting cache->cmd in
addition to cache->genid after dropping cache entries.

While being at it, set cache->cmd in cache_release() as well. This
shouldn't be necessary since zeroing cache->genid should suffice for
cache_update(), but better be consistent (and future-proof) here.

Fixes: eeda228c2d17 ("src: update cache if cmd is more specific")
Signed-off-by: Phil Sutter <phil@nwl.cc>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
src/rule.c