]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
perf hists: Update the column width for the "srcline" sort key
authorArnaldo Carvalho de Melo <acme@redhat.com>
Mon, 10 Aug 2015 19:53:54 +0000 (16:53 -0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 22 Oct 2015 21:43:12 +0000 (14:43 -0700)
commit5c23f8cd8a4a3ce31f65711f3b100055347b8751
tree1b7270701df82004749d5dbbd9cd3bb90ec1174a
parentd4cb7d0fc447e6117c99e45f3f4f698017201f2d
perf hists: Update the column width for the "srcline" sort key

commit e8e6d37e73e6b950c891c780745460b87f4755b6 upstream.

When we introduce a new sort key, we need to update the
hists__calc_col_len() function accordingly, otherwise the width
will be limited to strlen(header).

We can't update it when obtaining a line value for a column (for
instance, in sort__srcline_cmp()), because we reset it all when doing a
resort (see hists__output_recalc_col_len()), so we need to, from what is
in the hist_entry fields, set each of the column widths.

Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Andi Kleen <andi@firstfloor.org>
Cc: Jiri Olsa <jolsa@kernel.org>
Fixes: 409a8be61560 ("perf tools: Add sort by src line/number")
Link: http://lkml.kernel.org/n/tip-jgbe0yx8v1gs89cslr93pvz2@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
tools/perf/util/hist.c