]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
scsi: lpfc: Use int type to store negative error codes
authorQianfeng Rong <rongqianfeng@vivo.com>
Thu, 4 Sep 2025 13:23:51 +0000 (21:23 +0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Wed, 10 Sep 2025 02:11:44 +0000 (22:11 -0400)
commit5cffc679ad1de542ef8a247b12283cbe57511fc8
tree03fd8275c0235fd89c5222246479c67c60b3e268
parentb0aca7ae828560b103016620be7fd4c302da4176
scsi: lpfc: Use int type to store negative error codes

Change the 'ret' variable in lpfc_sli4_issue_wqe() from uint32_t to int,
as it needs to store either negative error codes or zero returned by
lpfc_sli4_wq_put().

Storing the negative error codes in unsigned type, doesn't cause an
issue at runtime but can be confusing.  Additionally, assigning negative
error codes to unsigned type may trigger a GCC warning when the
-Wsign-conversion flag is enabled.

No effect on runtime.

Signed-off-by: Qianfeng Rong <rongqianfeng@vivo.com>
Reviewed-by: Justin Tee <justin.tee@broadcom.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/lpfc/lpfc_sli.c