]> git.ipfire.org Git - thirdparty/xfsprogs-dev.git/commit
xfs: make tr_growdata a permanent transaction
authorBrian Foster <bfoster@redhat.com>
Fri, 19 Jul 2019 20:05:30 +0000 (16:05 -0400)
committerEric Sandeen <sandeen@redhat.com>
Fri, 19 Jul 2019 20:05:30 +0000 (16:05 -0400)
commit5d1b821b2bb13adab13fed82ea4621314bdec4c2
treea4d9a627dd249149ee3ff61484291f5095c98e0e
parent119a6c0b36b9654289f1992b5197f971d11d2c7d
xfs: make tr_growdata a permanent transaction

Source kernel commit: 945c941fcd82bac3a8ea2b89c635651f323bd609

The growdata transaction is used by growfs operations to increase
the data size of the filesystem. Part of this sequence involves
extending the size of the last preexisting AG in the fs, if
necessary. This is implemented by freeing the newly available
physical range to the AG.

tr_growdata is not a permanent transaction, however, and block
allocation transactions must be permanent to handle deferred frees
of AGFL blocks. If the grow operation extends an existing AG that
requires AGFL fixing, assert failures occur due to a populated dfops
list on a non-permanent transaction and the AGFL free does not
occur. This is reproduced (rarely) by xfs/104.

Change tr_growdata to a permanent transaction with a default log
count. This increases initial transaction reservation size, but
growfs is an infrequent and non-performance critical operation and
so should have minimal impact.

Reported-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Brian Foster <bfoster@redhat.com>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
[darrick: add a comment to the assert]
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
libxfs/xfs_trans_resv.c