]> git.ipfire.org Git - thirdparty/Python/cpython.git/commit
bpo-34521: Fix tests in test_multiprocessing_spawn to use correctly CMSG_SPACE (GH...
authorMiss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Fri, 28 Sep 2018 11:31:51 +0000 (04:31 -0700)
committerGitHub <noreply@github.com>
Fri, 28 Sep 2018 11:31:51 +0000 (04:31 -0700)
commit5d33ee1595767d68800fda13bc68b7b01dba5117
treede94408f500fd31b2b1d5277acd41f1f9e92bd7d
parentfe48b6df101aac10dc846fa6fd1a41f877e77025
bpo-34521: Fix tests in test_multiprocessing_spawn to use correctly CMSG_SPACE (GH-9613)

After some failures in AMD64 FreeBSD CURRENT Debug 3.x buildbots
regarding tests in test_multiprocessing_spawn and after examining
similar failures in test_socket, some errors in the calculation of
ancillary data buffers were found in multiprocessing.reduction.

CMSG_LEN() can often be used as the buffer size for recvmsg() to
receive a single item of ancillary data, but RFC 3542 requires portable
applications to use CMSG_SPACE() and thus include space for padding,
even when the item will be the last in the buffer.

The failures we experience are due to the usage of CMSG_LEN() instead of
CMSG_SPACE().
(cherry picked from commit 077061a7b24917aaf31057885c69919c5a553c88)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
Lib/multiprocessing/reduction.py