]> git.ipfire.org Git - thirdparty/qemu.git/commit
monitor: Reset HMP mon->rs in CHR_EVENT_OPEN
authorStratos Psomadakis <psomas@grnet.gr>
Mon, 15 Sep 2014 12:34:57 +0000 (15:34 +0300)
committerMichael Roth <mdroth@linux.vnet.ibm.com>
Mon, 5 Jan 2015 15:46:07 +0000 (09:46 -0600)
commit5d350980f6d6747adfbac4005044e75623c510af
treedbc6e2a4731fa482d6d9492e5447cba68b21799a
parentff1f973003848dbb02582f7a8f3694b7c89dcb5e
monitor: Reset HMP mon->rs in CHR_EVENT_OPEN

Commit cdaa86a54 ("Add G_IO_HUP handler for socket chardev") exposed a bug in
the way the HMP monitor handles its command buffer. When a client closes the
connection to the monitor, tcp_chr_read() will detect the G_IO_HUP condition
and call tcp_chr_disconnect() to close the server-side connection too. Due to
the fact that monitor reads 1 byte at a time (for each tcp_chr_read()), the
monitor readline state / buffers might contain junk (i.e. a half-finished
command). Thus, without calling readline_restart() on mon->rs in
CHR_EVENT_OPEN, future HMP commands will fail.

Signed-off-by: Stratos Psomadakis <psomas@grnet.gr>
Signed-off-by: Dimitris Aragiorgis <dimara@grnet.gr>
Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
(cherry picked from commit e5554e2015f8fb452135f7b1ce1976536266379c)
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
monitor.c