]> git.ipfire.org Git - thirdparty/qemu.git/commit
migration: Fix file migration with fdset
authorFabiano Rosas <farosas@suse.de>
Mon, 17 Jun 2024 18:57:17 +0000 (15:57 -0300)
committerMichael Tokarev <mjt@tls.msk.ru>
Sun, 30 Jun 2024 12:04:18 +0000 (15:04 +0300)
commit5d9f2461b4fe7d84b1a91d9fb55a0c1f46e48f98
treedb8e46d32d1d41355651ff8488a0fc4495a81695
parent1229d6071403679deacd49b01083b96ba98a0259
migration: Fix file migration with fdset

When the "file:" migration support was added we missed the special
case in the qemu_open_old implementation that allows for a particular
file name format to be used to refer to a set of file descriptors that
have been previously provided to QEMU via the add-fd QMP command.

When using this fdset feature, we should not truncate the migration
file because being given an fd means that the management layer is in
control of the file and will likely already have some data written to
it. This is further indicated by the presence of the 'offset'
argument, which indicates the start of the region where QEMU is
allowed to write.

Fix the issue by replacing the O_TRUNC flag on open by an ftruncate
call, which will take the offset into consideration.

Fixes: 385f510df5 ("migration: file URI offset")
Suggested-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Prasad Pandit <pjp@fedoraproject.org>
Reviewed-by: Peter Xu <peterx@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Fabiano Rosas <farosas@suse.de>
(cherry picked from commit 6d3279655ac49b806265f08415165f471d33e032)
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
(Mjt: context fixup in migration/file.c due to missing
 v8.2.0-1958-gb7b03eb614d0 "migration/multifd: Add outgoing QIOChannelFile support")
migration/file.c