]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Fix MVCC bug with prepared xact with subxacts on standby
authorHeikki Linnakangas <heikki.linnakangas@iki.fi>
Thu, 27 Jun 2024 18:06:32 +0000 (21:06 +0300)
committerHeikki Linnakangas <heikki.linnakangas@iki.fi>
Thu, 27 Jun 2024 18:09:15 +0000 (21:09 +0300)
commit5dea6628b32d8092e789d9e31509ed74840a271e
treefd5e77cdf78e3a60cd27215e1b87c483373b71d3
parent266454f192e8f67e8e5e8e9f7667d7c8c77de232
Fix MVCC bug with prepared xact with subxacts on standby

We did not recover the subtransaction IDs of prepared transactions
when starting a hot standby from a shutdown checkpoint. As a result,
such subtransactions were considered as aborted, rather than
in-progress. That would lead to hint bits being set incorrectly, and
the subtransactions suddenly becoming visible to old snapshots when
the prepared transaction was committed.

To fix, update pg_subtrans with prepared transactions's subxids when
starting hot standby from a shutdown checkpoint. The snapshots taken
from that state need to be marked as "suboverflowed", so that we also
check the pg_subtrans.

Backport to all supported versions.

Discussion: https://www.postgresql.org/message-id/6b852e98-2d49-4ca1-9e95-db419a2696e0@iki.fi
src/backend/access/transam/twophase.c
src/backend/access/transam/xlog.c
src/backend/storage/ipc/procarray.c
src/backend/storage/ipc/standby.c
src/include/storage/standby.h
src/test/recovery/t/009_twophase.pl
src/tools/pgindent/typedefs.list