]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
IB/mthca: fix return value of error branch in mthca_init_cq()
authorXiongfeng Wang <wangxiongfeng2@huawei.com>
Fri, 20 Nov 2020 01:57:02 +0000 (09:57 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 2 Dec 2020 07:34:43 +0000 (08:34 +0100)
commit5e66950aace56d8d470210db78c9fa256a28b355
treea5bb92538c031615949ef6eb61dd15181939baa5
parentcea2c7b1eca14b4f43179a6722c1e00284cfb1cc
IB/mthca: fix return value of error branch in mthca_init_cq()

[ Upstream commit 6830ff853a5764c75e56750d59d0bbb6b26f1835 ]

We return 'err' in the error branch, but this variable may be set as zero
by the above code. Fix it by setting 'err' as a negative value before we
goto the error label.

Fixes: 74c2174e7be5 ("IB uverbs: add mthca user CQ support")
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Link: https://lore.kernel.org/r/1605837422-42724-1-git-send-email-wangxiongfeng2@huawei.com
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Xiongfeng Wang <wangxiongfeng2@huawei.com>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/infiniband/hw/mthca/mthca_cq.c