]> git.ipfire.org Git - thirdparty/qemu.git/commit
s390x/cpumodel: Fix harmless misuse of visit_check_struct()
authorMarkus Armbruster <armbru@redhat.com>
Tue, 5 May 2020 10:19:01 +0000 (12:19 +0200)
committerMarkus Armbruster <armbru@redhat.com>
Wed, 27 May 2020 05:45:25 +0000 (07:45 +0200)
commit5e959d2e6e698af86a7064ead87ebe47706d99c7
tree2eb10fa0dfd8932a44f8cb67ba656711203b590c
parent56f9dde414053410857d0083e92e5b1b45cf33dc
s390x/cpumodel: Fix harmless misuse of visit_check_struct()

Commit e47970f51d "s390x/cpumodel: Fix query-cpu-model-FOO error API
violations" neglected to change visit_check_struct()'s Error **
argument along with the others.  If visit_check_struct() failed, we'd
take the success path.  Fortunately, it can't fail here:
qobject_input_check_struct() checks we consumed the whole dictionary,
and to get here, we did.  Fix it anyway.

Cc: David Hildenbrand <david@redhat.com>
Cc: Cornelia Huck <cohuck@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
Message-Id: <20200505101908.6207-4-armbru@redhat.com>
target/s390x/cpu_models.c