]> git.ipfire.org Git - people/ms/linux.git/commit
nfs d_revalidate() is too trigger-happy with d_drop()
authorAl Viro <viro@ZenIV.linux.org.uk>
Thu, 29 Apr 2010 02:10:43 +0000 (03:10 +0100)
committerGreg Kroah-Hartman <gregkh@suse.de>
Wed, 26 May 2010 21:27:07 +0000 (14:27 -0700)
commit5ea176dcda8200cce3ca9e208fba5ab49ebb786d
treed50c5d714d12b9c9d262210bbe47e7ab3847c5e2
parentd130b918879aa06a82cfac3bec5ec88e79a05f30
nfs d_revalidate() is too trigger-happy with d_drop()

commit d9e80b7de91db05c1c4d2e5ebbfd70b3b3ba0e0f upstream.

If dentry found stale happens to be a root of disconnected tree, we
can't d_drop() it; its d_hash is actually part of s_anon and d_drop()
would simply hide it from shrink_dcache_for_umount(), leading to
all sorts of fun, including busy inodes on umount and oopsen after
that.

Bug had been there since at least 2006 (commit c636eb already has it),
so it's definitely -stable fodder.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
fs/nfs/dir.c