]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
net: ethtool: take rss_lock for all rxfh changes
authorJakub Kicinski <kuba@kernel.org>
Thu, 26 Jun 2025 20:28:46 +0000 (13:28 -0700)
committerJakub Kicinski <kuba@kernel.org>
Mon, 30 Jun 2025 15:41:24 +0000 (08:41 -0700)
commit5ec353dbff4fd5fed21fa2104c3e01444cc06c89
tree0b601732612e3082f713db929b8b10877d6bef14
parent99e3eb454cc48b9f2691256780aeb247bdc0ee3d
net: ethtool: take rss_lock for all rxfh changes

Always take the rss_lock in ethtool_set_rxfh(). We will want to
make a similar change in ethtool_set_rxfh_fields() and some
drivers lock that callback regardless of rss context ID being set.
Having some callbacks locked unconditionally and some only if
context ID is set would be very confusing.

ethtool handling is under rtnl_lock, so rss_lock is very unlikely
to ever be congested.

Link: https://patch.msgid.link/20250626202848.104457-2-kuba@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/ethtool/ioctl.c