]> git.ipfire.org Git - thirdparty/git.git/commit
revert: fix parse_options_concat() leak
authorÆvar Arnfjörð Bjarmason <avarab@gmail.com>
Tue, 8 Nov 2022 18:17:50 +0000 (19:17 +0100)
committerJunio C Hamano <gitster@pobox.com>
Mon, 21 Nov 2022 03:32:48 +0000 (12:32 +0900)
commit603f2f5719f8a85996d5f20cf0e56186c149b923
tree7ca62e018a6d91bdeb989dfeea6c7bdde2be2659
parentd1ec656d68fe6dfc421a5c96d009fbd2e1fa76f3
revert: fix parse_options_concat() leak

Free memory from parse_options_concat(), which comes from code
originally added (then extended) in [1].

At this point we could get several more tests leak-free by free()-ing
the xstrdup() just above the line being changed, but that one's
trickier than it seems. The sequencer_remove_state() function
supposedly owns it, but sometimes we don't call it. I have a fix for
it, but it's non-trivial, so let's fix the easy one first.

1. c62f6ec341b (revert: add --ff option to allow fast forward when
   cherry-picking, 2010-03-06)

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Taylor Blau <me@ttaylorr.com>
builtin/revert.c
t/t3429-rebase-edit-todo.sh