]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
selftests/x86/lam: Fix clean up fds in do_uring() and allocate_dsa_pasid()
authorMalaya Kumar Rout <malayarout91@gmail.com>
Wed, 9 Apr 2025 13:53:37 +0000 (19:23 +0530)
committerIngo Molnar <mingo@kernel.org>
Wed, 9 Apr 2025 19:30:37 +0000 (21:30 +0200)
commit60567e93c05d7064c93830cf4bf0d2c58f11b2f2
tree94615c5ee850e83d916dfe0209ab7101830c56d7
parentfc1cd60042b3df1d162278461c7a87f0362502b8
selftests/x86/lam: Fix clean up fds in do_uring() and allocate_dsa_pasid()

Resolve minor fd leaks reported by cppcheck in lam.c.

Specifically, the 'file_fd' and 'fd' were not closed in do_uring()
and allocate_dsa_pasid() functions, respectively.

cppcheck output before this patch:

  tools/testing/selftests/x86/lam.c:685:3: error: Resource leak: file_fd [resourceLeak]
  tools/testing/selftests/x86/lam.c:693:3: error: Resource leak: file_fd [resourceLeak]
  tools/testing/selftests/x86/lam.c:1195:2: error: Resource leak: fd [resourceLeak]

cppcheck output after this patch:

  No resource leaks found

While this is a standalone test tool that doesn't really leak anything
in practice, as exit() cleans it up all, clean up resources nevertheless.

[ mingo: Updated the changelog. ]

Signed-off-by: Malaya Kumar Rout <malayarout91@gmail.com>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Link: https://lore.kernel.org/r/20250409135341.28987-1-malayarout91@gmail.com
tools/testing/selftests/x86/lam.c