]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
sched_ext: Remove unnecessary cpu_relax()
authorDavid Vernet <void@manifault.com>
Mon, 14 Oct 2024 17:58:30 +0000 (12:58 -0500)
committerTejun Heo <tj@kernel.org>
Mon, 14 Oct 2024 23:23:49 +0000 (13:23 -1000)
commit60e339be100d7d49e13616bd8b4b1b864f0a64a0
tree0abc72d60145c53ea2b4a3d82199dc3257f3e840
parentb07996c7abac0fe3f70bf74b0b3f76eb7852ef5a
sched_ext: Remove unnecessary cpu_relax()

As described in commit b07996c7abac ("sched_ext: Don't hold
scx_tasks_lock for too long"), we're doing a cond_resched() every 32
calls to scx_task_iter_next() to avoid RCU and other stalls. That commit
also added a cpu_relax() to the codepath where we drop and reacquire the
lock, but as Waiman described in [0], cpu_relax() should only be
necessary in busy loops to avoid pounding on a cacheline (or to allow a
hypertwin to more fully utilize a core).

Let's remove the unnecessary cpu_relax().

[0]: https://lore.kernel.org/all/35b3889b-904a-4d26-981f-c8aa1557a7c7@redhat.com/

Cc: Waiman Long <llong@redhat.com>
Signed-off-by: David Vernet <void@manifault.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
kernel/sched/ext.c