]> git.ipfire.org Git - thirdparty/libvirt.git/commit
Remove all direct use of getenv
authorDaniel P. Berrange <berrange@redhat.com>
Wed, 9 Oct 2013 10:18:15 +0000 (11:18 +0100)
committerDaniel P. Berrange <berrange@redhat.com>
Tue, 29 Oct 2013 16:13:03 +0000 (16:13 +0000)
commit61fe5eebda163122dcf8a2980e901a5c6dab8777
treeef21f2a6dceea7b7e0867aa0d6fd27ebabc0828d
parentef0476456a9d9384a4507acbfc99fa5c0d2cadd9
Remove all direct use of getenv

Unconditional use of getenv is not secure in setuid env.
While not all libvirt code runs in a setuid env (since
much of it only exists inside libvirtd) this is not always
clear to developers. So make all the code paranoid, even
if it only ever runs inside libvirtd.

Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
(cherry picked from commit 1e4a02bdfe6307f93763fa2c9681f280c564aee5)
17 files changed:
daemon/libvirtd.c
src/driver.c
src/libvirt.c
src/locking/lock_daemon.c
src/locking/lock_driver_lockd.c
src/locking/lock_manager.c
src/lxc/lxc_driver.c
src/remote/remote_driver.c
src/rpc/virnettlscontext.c
src/util/virauth.c
src/util/virfile.c
src/util/virlog.c
src/util/virrandom.c
src/util/virutil.c
src/vbox/vbox_XPCOMCGlue.c
src/vbox/vbox_tmpl.c
tools/virsh.c